Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5334#discussion_r27680698
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala ---
@@ -226,7 +224,7 @@ private[sql] case class ParquetRelation2(
private var commonMetadataStatuses: Array[FileStatus] = _
// Parquet footer cache.
- var footers: Map[FileStatus, Footer] = _
+ var footers: Map[Path, Footer] = _
--- End diff --
I think the advantage to making this a `Map[FileStatus, Footer]` is that if
the file changes the cache is automatically invalidated. Though perhaps this
does not matter if we are also caching those?
Also, I think that we need to bound the size of this, perhaps in some
global way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
