srowen commented on a change in pull request #29608:
URL: https://github.com/apache/spark/pull/29608#discussion_r481152252
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##########
@@ -152,7 +152,7 @@ class ExpressionsSchemaSuite extends QueryTest with
SharedSparkSession {
val outputSize = outputs.size
val headerSize = header.size
- val expectedOutputs: Seq[QueryOutput] = {
+ val (expectedMissExamples, expectedOutputs): (Array[String],
Seq[QueryOutput]) = {
Review comment:
No big deal, but the types can just be added to the two tuple elements,
instead of declaring them separately as a type for the whole tuple
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##########
@@ -161,14 +161,28 @@ class ExpressionsSchemaSuite extends QueryTest with
SharedSparkSession {
s"Expected $expectedSize blocks in result file but got " +
s"${outputSize + headerSize}. Try regenerate the result files.")
- Seq.tabulate(outputSize) { i =>
+ val numberOfQueries = lines(2).split(":")(1).trim.toInt
+ val numberOfMissExample = lines(3).split(":")(1).trim.toInt
Review comment:
miss -> missed or missing, in most cases in this change
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##########
@@ -161,14 +161,28 @@ class ExpressionsSchemaSuite extends QueryTest with
SharedSparkSession {
s"Expected $expectedSize blocks in result file but got " +
s"${outputSize + headerSize}. Try regenerate the result files.")
- Seq.tabulate(outputSize) { i =>
+ val numberOfQueries = lines(2).split(":")(1).trim.toInt
+ val numberOfMissExample = lines(3).split(":")(1).trim.toInt
+ val missExamples = lines(4).split(":")(1).trim.split(",")
+ val expectedOutputs = Seq.tabulate(outputSize) { i =>
val segments = lines(i + headerSize).split('|')
QueryOutput(
className = segments(1).trim,
funcName = segments(2).trim,
sql = segments(3).trim,
schema = segments(4).trim)
}
+
+ // Ensure consistency of the result file.
+ assert(numberOfQueries == expectedOutputs.size,
+ s"outputs size: ${expectedOutputs.size} not same as numberOfQueries:
$numberOfQueries " +
+ "record in result file. Try regenerate the result files.")
Review comment:
regenerate -> regenerating
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
