cloud-fan commented on a change in pull request #29614:
URL: https://github.com/apache/spark/pull/29614#discussion_r481931833



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1224,4 +1224,68 @@ class AdaptiveQueryExecSuite
       })
     }
   }
+
+  test("SPARK-32765: EliminateJoinToEmptyRelation should respect exchange 
behavior " +
+    "when canChangeNumPartitions == false") {
+    withSQLConf(
+      SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+      SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> Long.MaxValue.toString,

Review comment:
       do we need it? the test uses hint to guarantee broadcast join




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to