viirya commented on a change in pull request #29572:
URL: https://github.com/apache/spark/pull/29572#discussion_r482198804
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArray.scala
##########
@@ -50,7 +58,7 @@ private[sql] class ExternalAppendOnlyUnsafeRowArray(
initialSize: Int,
pageSizeBytes: Long,
numRowsInMemoryBufferThreshold: Int,
- numRowsSpillThreshold: Int) extends Logging {
+ numRowsSpillThreshold: Int) extends AppendOnlyUnsafeRowArray with Logging {
Review comment:
For core component like this, I remember we rarely change its
inheritance. It is easily to have performance regression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
