maropu commented on a change in pull request #29585:
URL: https://github.com/apache/spark/pull/29585#discussion_r482589188
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1580,23 +1580,36 @@ object ReplaceDistinctWithAggregate extends
Rule[LogicalPlan] {
* Replaces logical [[Deduplicate]] operator with an [[Aggregate]] operator.
*/
object ReplaceDeduplicateWithAggregate extends Rule[LogicalPlan] {
- def apply(plan: LogicalPlan): LogicalPlan = plan transform {
- case Deduplicate(keys, child) if !child.isStreaming =>
- val keyExprIds = keys.map(_.exprId)
- val aggCols = child.output.map { attr =>
- if (keyExprIds.contains(attr.exprId)) {
- attr
- } else {
- Alias(new First(attr).toAggregateExpression(),
attr.name)(attr.exprId)
Review comment:
Found by the integrity check:
https://github.com/apache/spark/pull/29585/files#diff-27c76f96a7b2733ecfd6f46a1716e153R238
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1580,23 +1580,36 @@ object ReplaceDistinctWithAggregate extends
Rule[LogicalPlan] {
* Replaces logical [[Deduplicate]] operator with an [[Aggregate]] operator.
*/
object ReplaceDeduplicateWithAggregate extends Rule[LogicalPlan] {
- def apply(plan: LogicalPlan): LogicalPlan = plan transform {
- case Deduplicate(keys, child) if !child.isStreaming =>
- val keyExprIds = keys.map(_.exprId)
- val aggCols = child.output.map { attr =>
- if (keyExprIds.contains(attr.exprId)) {
- attr
- } else {
- Alias(new First(attr).toAggregateExpression(),
attr.name)(attr.exprId)
Review comment:
NOTE: Found by the integrity check:
https://github.com/apache/spark/pull/29585/files#diff-27c76f96a7b2733ecfd6f46a1716e153R238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
