cloud-fan commented on a change in pull request #29502:
URL: https://github.com/apache/spark/pull/29502#discussion_r482712104
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -1359,16 +1359,23 @@ class SessionCatalog(
val info = new ExpressionInfo(funcDefinition.className,
func.database.orNull, func.funcName)
val builder =
functionBuilder.getOrElse {
- val className = funcDefinition.className
- if (!Utils.classIsLoadable(className)) {
- throw new AnalysisException(s"Can not load class '$className' when
registering " +
- s"the function '$func', please make sure it is on the classpath")
- }
- makeFunctionBuilder(func.unquotedString, className)
+ requireFunctionClassExists(funcDefinition)
+ makeFunctionBuilder(func.unquotedString, funcDefinition.className)
}
functionRegistry.registerFunction(func, info, builder)
}
+ /**
+ * Make sure function class is on the classpath.
+ */
+ def requireFunctionClassExists(funcDefinition: CatalogFunction): Unit = {
+ val className = funcDefinition.className
+ if (!Utils.classIsLoadable(className)) {
+ throw new AnalysisException(s"Can not load class '$className' when
registering " +
+ s"the function '${funcDefinition.identifier}', please make sure it is
on the classpath")
Review comment:
how about `funcDefinition.identifier.unquotedString`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
