maryannxue commented on a change in pull request #29593: URL: https://github.com/apache/spark/pull/29593#discussion_r483147875
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala ########## @@ -91,7 +91,11 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product { private val tags: mutable.Map[TreeNodeTag[_], Any] = mutable.Map.empty protected def copyTagsFrom(other: BaseType): Unit = { Review comment: Agree with @cloud-fan 's reasoning and proposed fix. The only worry is that we're not 100% sure if we are breaking things somewhere else, but the tests don't say so yet. Can't think of an approach that would have less impact yet fix this problem perfectly. Let's go with this approach then. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org