Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3098#issuecomment-89083630 @debasish83 The code style still need fixes. On the high level, I think having variable `num` is not necessary. Let's do a global num in this PR and see whether users ask for variable `num`. @coderxiang added `topByKey` recently, so it would be nice if we can reuse the implementation in couple places.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org