Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5116#discussion_r27708997
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestClient.scala ---
    @@ -228,20 +282,14 @@ private[deploy] class StandaloneRestClient extends 
Logging {
     
       /** Report the status of a newly created submission. */
       private def reportSubmissionStatus(
    -      master: String,
           submitResponse: CreateSubmissionResponse): Unit = {
    -    if (submitResponse.success) {
    -      val submissionId = submitResponse.submissionId
    -      if (submissionId != null) {
    -        logInfo(s"Submission successfully created as $submissionId. 
Polling submission state...")
    -        pollSubmissionStatus(master, submissionId)
    -      } else {
    -        // should never happen
    -        logError("Application successfully submitted, but submission ID 
was not provided!")
    -      }
    +    val submissionId = submitResponse.submissionId
    +    if (submissionId != null) {
    +      logInfo(s"Submission successfully created as $submissionId. Polling 
submission state...")
    +      pollSubmissionStatus(submissionId)
         } else {
    -      val failMessage = Option(submitResponse.message).map { ": " + _ 
}.getOrElse("")
    -      logError("Application submission failed" + failMessage)
    +      // should never happen
    +      logError("Application successfully submitted, but submission ID was 
not provided!")
    --- End diff --
    
    Why this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to