gengliangwang commented on a change in pull request #29364: URL: https://github.com/apache/spark/pull/29364#discussion_r483626546
########## File path: sql/core/src/test/scala/org/apache/spark/status/api/v1/sql/SqlResourceWithActualMetricsSuite.scala ########## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.status.api.v1.sql + +import java.net.URL +import java.text.SimpleDateFormat + +import org.json4s.DefaultFormats +import org.json4s.jackson.JsonMethods + +import org.apache.spark.SparkConf +import org.apache.spark.deploy.history.HistoryServerSuite.getContentAndCode +import org.apache.spark.sql.DataFrame +import org.apache.spark.sql.execution.metric.SQLMetricsTestUtils +import org.apache.spark.sql.test.SharedSparkSession + +case class Person(id: Int, name: String, age: Int) +case class Salary(personId: Int, salary: Double) + +/** + * Sql Resource Public API Unit Tests running query and extracting the metrics. + */ +class SqlResourceWithActualMetricsSuite extends SharedSparkSession with SQLMetricsTestUtils { + + import testImplicits._ + + // Exclude nodes which may not have the metrics + val excludedNodes = List("WholeStageCodegen", "Project", "SerializeFromObject") + + implicit val formats = new DefaultFormats { + override def dateFormatter = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss") + } + + override def sparkConf: SparkConf = { + super.sparkConf.set("spark.ui.enabled", "true") + } + + test("Check Sql Rest Api Endpoints") { + // Materalize result DataFrame + val count = getDF().count() + assert(count == 2, s"Expected Query Count is 2 but received: $count") + + // Spark apps launched by local-mode seems not having `attemptId` as default Review comment: I am not sure about this. It seems so from the doc https://spark.apache.org/docs/latest/monitoring.html#rest-api. CC @jiangxb1987 @srowen @Ngone51 Is there attemptId for local mode? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
