dongjoon-hyun commented on a change in pull request #29647:
URL: https://github.com/apache/spark/pull/29647#discussion_r483741668
##########
File path: sql/core/src/test/resources/sql-tests/inputs/operators.sql
##########
@@ -95,3 +95,9 @@ select width_bucket(5.35, 0.024, 10.06, null);
select width_bucket(5.35, 0.024, 10.06, -5);
select width_bucket(5.35, 0.024, 10.06, 9223372036854775807L); -- long max
value
select width_bucket(5.35, 0.024, 10.06, 9223372036854775807L - 1);
+
+-- special floating values
+select double('NaN') = double('NaN'), double('NaN') >= double('NaN'),
double('NaN') <= double('NaN');
+select double('NaN') > double("+Infinity"), double("+Infinity") <
double('NaN'), double('NaN') > double('NaN');
+select 0.0 = -0.0, 0.0 >= -0.0, 0.0 <= -0.0;
+select 0.0 > -0.0, 0.0 < -0.0;
Review comment:
This doesn't add a new test coverage because this has the same result
with Spark 3.0.0.
```
spark-sql> select version();
3.0.0 3fdfce3120f307147244e5eaf46d61419a723d50
spark-sql> select double('NaN') = double('NaN'), double('NaN') >=
double('NaN'), double('NaN') <= double('NaN');
true true true
spark-sql> select double('NaN') > double("+Infinity"), double("+Infinity") <
double('NaN'), double('NaN') > double('NaN');
true true false
spark-sql> select 0.0 = -0.0, 0.0 >= -0.0, 0.0 <= -0.0;
true true true
spark-sql> select 0.0 > -0.0, 0.0 < -0.0;
false false
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
