Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4015#discussion_r27710241
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
    @@ -110,7 +110,8 @@ class TestHiveContext(sc: SparkContext) extends 
HiveContext(sc) {
         /** Fewer partitions to speed up testing. */
         protected[sql] override lazy val conf: SQLConf = new SQLConf {
           override def numShufflePartitions: Int = 
getConf(SQLConf.SHUFFLE_PARTITIONS, "5").toInt
    -      override def dialect: String = getConf(SQLConf.DIALECT, "hiveql")
    +      // TODO as in unit test, conf.clear() probably be called, actually 
all we need is reset
    --- End diff --
    
    What do you mean?  Why the change below?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to