zero323 commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-687918887
__Update__:
At the moment:
- both MyPy and Flake8 tests pass with
- `flake8==3.8.3`
- `flake8-pyi==20.5.0`
and F401 (unused import) excludes on a few `pyi` files.
- With `flake8==3.7.*` all tests pass with excludes as [added to tox
fiile](https://github.com/apache/spark/pull/29591/files#diff-3d0e2fd61fb61f36804ed2ea3f8ff95f).
Additionally to F401 violations, flake8 doesn't seem to understand specific
type ignores.
- With `flake8==3.5.0` there are no file specific ignores, so we get
multiple failures. This could be addressed, for the time being, by either
excluding problematic files from mypy or flake8 tests, and adjusting inline
ignores. However, it is rather brute-force solution, and would require some
discussion about the priorities.
From the perspective of this PR, an ideal solution would be an update of
test dependencies, but I am not sure if that's realistic at the moment (hate to
ask, but do you have any thoughts about it @shaneknapp?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
