HyukjinKwon commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r484188746
##########
File path: examples/src/main/python/ml/estimator_transformer_param_example.py
##########
@@ -54,7 +56,7 @@
print(model1.extractParamMap())
# We may alternatively specify parameters using a Python dictionary as a
paramMap
- paramMap = {lr.maxIter: 20}
+ paramMap: Dict[Param, Any] = {lr.maxIter: 20}
Review comment:
I don't object to having the type hints in the examples but I guess we
should type everything in examples if we want. We could discuss and do
separately - we'd likely have to file multiple followup JIRAs under SPARK-32681.
I was thinking it's good to port the PySpark type hints alone first with
minimized diff to other codes in Spark in this JIRA/PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
