sandeep-katta commented on a change in pull request #29649:
URL: https://github.com/apache/spark/pull/29649#discussion_r484189537
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -1329,8 +1329,7 @@ private[client] class Shim_v3_0 extends Shim_v2_3 {
isSrcLocal: Boolean): Unit = {
val session = SparkSession.getActiveSession
assert(session.nonEmpty)
- val database = session.get.sessionState.catalog.getCurrentDatabase
- val table = hive.getTable(database, tableName)
+ val table = hive.getTable(tableName)
Review comment:
> If the question is why `Shim.loadPartition` doesn't take database as
an argument, yes I think we can change to take. But looks like it's to match
with `Hive.loadPartition`'s signature.
+1 for this , I will update the API signature to take the database name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
