Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/4419#issuecomment-89109912
@jkbradley Thanks for the quick response.
Sure I can start the comparison. Meanwhile, I've read your comments in the
Gibbs PR and I agree with the general proposal. Let me know if you think we
should get rid of the OnlineLDA class (current builder version) and move the
run function back to LDA.
I'm not sure if it's proper to introduce many specific arguments
(miniBatchFraction, tau_0 and kappa) to LDA. That's my only concern.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
