maropu commented on a change in pull request #29585:
URL: https://github.com/apache/spark/pull/29585#discussion_r484898513
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1596,7 +1596,9 @@ object ReplaceDeduplicateWithAggregate extends
Rule[LogicalPlan] {
// we append a literal when the grouping key list is empty so that the
result aggregate
// operator is properly treated as a grouping aggregation.
val nonemptyKeys = if (keys.isEmpty) Literal(1) :: Nil else keys
- Aggregate(nonemptyKeys, aggCols, child)
+ val newAgg = Aggregate(nonemptyKeys, aggCols, child)
+ val attrMapping = d.output.zip(newAgg.output)
Review comment:
Looks the length of `Aggregate.output` is `aggCols.length` and
`aggCols.length` is the same with `Deduplicate.child.length`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
