Gaurangi94 commented on a change in pull request #29630:
URL: https://github.com/apache/spark/pull/29630#discussion_r485046482
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -471,7 +471,7 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
val newLastScanTime = clock.getTimeMillis()
logDebug(s"Scanning $logDir with lastScanTime==$lastScanTime")
- val updated = Option(fs.listStatus(new
Path(logDir))).map(_.toSeq).getOrElse(Nil)
+ val updated = Option(fs.globStatus(new Path(logDir +
"/*"))).map(_.toSeq).getOrElse(Nil)
Review comment:
The reason we chose to go with glob-pattern is that our service creates
short-lived YARN clusters on which Spark applications are run. Log data goes to
directories in a remote file-system. Since the number of these clusters can be
really large, glob pattern would better fit our use-case, than a static list
would.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
