BryanCutler commented on a change in pull request #29686:
URL: https://github.com/apache/spark/pull/29686#discussion_r485164592
##########
File path: pom.xml
##########
@@ -2329,19 +2329,26 @@
</exclusion>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-databind</artifactId>
+ <artifactId>jackson-core</artifactId>
</exclusion>
<exclusion>
<groupId>io.netty</groupId>
- <artifactId>netty-buffer</artifactId>
+ <artifactId>netty-common</artifactId>
</exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.arrow</groupId>
+ <artifactId>arrow-memory-netty</artifactId>
Review comment:
Arrow Java separated the `netty-buffer` dependency into another
artifact, to control which allocator is used. The `netty-buffer` was the
previous default allocator and the other option is `arrow-memory-unsafe`. The
later uses unsafe directly to allocate and release all buffers and does not
have the optimizations built in to `netty-buffer`, so I will leave this as-is
to maintain performance. It is possible this could be changed and removed in
future work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
