mccheah commented on a change in pull request #28618:
URL: https://github.com/apache/spark/pull/28618#discussion_r485993848
##########
File path:
core/src/main/java/org/apache/spark/shuffle/sort/io/LocalDiskShuffleDataIO.java
##########
@@ -35,12 +37,13 @@ public LocalDiskShuffleDataIO(SparkConf sparkConf) {
}
@Override
- public ShuffleExecutorComponents executor() {
- return new LocalDiskShuffleExecutorComponents(sparkConf);
+ public ShuffleDriverComponents initializeShuffleDriverComponents() {
+ return new LocalDiskShuffleDriverComponents(sparkConf);
}
@Override
- public ShuffleDriverComponents driver() {
- return new LocalDiskShuffleDriverComponents();
+ public ShuffleExecutorComponents initializeShuffleExecutorComponents(
+ String appId, String execId, Map<String, String> extraConfigs) {
+ return new LocalDiskShuffleExecutorComponents(sparkConf);
Review comment:
Don't think it's particularly important that it's empty and ignored -
maybe just add a warning log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
