dongjoon-hyun commented on a change in pull request #29701:
URL: https://github.com/apache/spark/pull/29701#discussion_r486000587
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala
##########
@@ -170,18 +170,20 @@ class DataStreamReaderWriterSuite extends StreamTest with
BeforeAndAfter {
LastOptions.clear()
- df.writeStream
+ val query = df.writeStream
.format("org.apache.spark.sql.streaming.test")
- .option("opt1", "1")
- .options(Map("opt2" -> "2"))
Review comment:
Previously, the test case used the same options here and line 162~163.
This hides this test coverage bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
