AngersZhuuuu commented on a change in pull request #29692:
URL: https://github.com/apache/spark/pull/29692#discussion_r486141369
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -248,6 +249,74 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends
Rule[SparkPlan] {
} else {
smj
}
+
+ case bnl @ BroadcastNestedLoopJoinExec(leftChild, rightChild, buildSide,
joinType, _, _) =>
+ def resolveBroadcastNLJoinSkew(
Review comment:
> This is just a suggestion; could we share code between smj and bnl
cases? Most parts look duplicated.
After all detail ok, I will start this work. I quite agree with this
suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
