cloud-fan commented on a change in pull request #29316:
URL: https://github.com/apache/spark/pull/29316#discussion_r486144915
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
##########
@@ -402,6 +403,22 @@ case class PreprocessTableInsertion(conf: SQLConf) extends
Rule[LogicalPlan] {
s"including ${staticPartCols.size} partition column(s) having
constant value(s).")
}
+ val partitionsTrackedByCatalog = conf.manageFilesourcePartitions &&
+ catalogTable.isDefined &&
+ catalogTable.get.partitionColumnNames.nonEmpty &&
+ catalogTable.get.tracksPartitionsInCatalog
+ // check static partition
+ if (partitionsTrackedByCatalog &&
+ normalizedPartSpec.nonEmpty &&
+ staticPartCols.size == partColNames.size) {
Review comment:
why do we need this check `staticPartCols.size == partColNames.size`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
