cxzl25 commented on a change in pull request #29316:
URL: https://github.com/apache/spark/pull/29316#discussion_r486159008
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
##########
@@ -402,6 +403,22 @@ case class PreprocessTableInsertion(conf: SQLConf) extends
Rule[LogicalPlan] {
s"including ${staticPartCols.size} partition column(s) having
constant value(s).")
}
+ val partitionsTrackedByCatalog = conf.manageFilesourcePartitions &&
+ catalogTable.isDefined &&
+ catalogTable.get.partitionColumnNames.nonEmpty &&
+ catalogTable.get.tracksPartitionsInCatalog
+ // check static partition
+ if (partitionsTrackedByCatalog &&
+ normalizedPartSpec.nonEmpty &&
+ staticPartCols.size == partColNames.size) {
Review comment:
Spark/Hive allows the partition value to be empty for dynamic partition
write.
```
Loading data to table x.t1 partition (d=1, h=null)
Time taken for load dynamic partitions : 203
Loading partition {d=1, h=__HIVE_DEFAULT_PARTITION__}
Time taken for adding to write entity : 1
Partition x.t1{d=1, h=__HIVE_DEFAULT_PARTITION__} stats: [numFiles=1,
numRows=1, totalSize=201, rawDataSize=85]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
