cloud-fan commented on a change in pull request #29712:
URL: https://github.com/apache/spark/pull/29712#discussion_r486250807
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
##########
@@ -190,4 +191,18 @@ object DataSourceUtils {
case LegacyBehaviorPolicy.LEGACY =>
RebaseDateTime.rebaseGregorianToJulianMicros
case LegacyBehaviorPolicy.CORRECTED => identity[Long]
}
+
+ private[sql] def checkDuplicateOptions(
+ extraOptionsMap: Map[String, String], table: CatalogTable): Unit = {
Review comment:
we should take care of case sensitivity:
```
def checkConflictingOptions(table: CatalogTable, options:
CaseInsensitiveStringMap): Unit = {
table.storage.properties.foreach { case (k, v) =>
if (options.get(k) == v) throw ...
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
