mingjialiu commented on pull request #29564: URL: https://github.com/apache/spark/pull/29564#issuecomment-690810458
> > The fix LGTM, can you add a test? > > Regarding test coverage, it's a bit tricky to repro in a unit test. Can I get some pointers on populating different expression ids for the same column? Or test suggestions? > > The key to repro is to have the same column assigned different expression Ids. > Relative implementation : [preserve old expressionId if column not found](https://github.com/apache/spark/blob/branch-2.4/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala#L285) > Explained details in email. > The fix LGTM, can you add a test? Test added. Please review. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
