cloud-fan commented on a change in pull request #29564:
URL: https://github.com/apache/spark/pull/29564#discussion_r486821529
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala
##########
@@ -393,6 +393,29 @@ class DataSourceV2Suite extends QueryTest with
SharedSQLContext {
}
}
}
+
+ test("SPARK-32708: same columns with different ExprIds should be equal after
canonicalization ") {
Review comment:
If we don't have an end-to-end test, how about a low-level UT? Create
two `DataSourceV2ScanExec` instances and check `scan1.sameResult(scan2)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
