dongjoon-hyun opened a new pull request #29730:
URL: https://github.com/apache/spark/pull/29730


   ### What changes were proposed in this pull request?
   
   This PR aims to add `sinkParameter`  to check sink options robustly and 
independently in DataStreamReaderWriterSuite
   
   ### Why are the changes needed?
   
   `LastOptions.parameters` is designed to catch `sourceSchema`, 
`createSource`, `createSink`. However, `StreamQuery.stop` invokes 
`createSource` and reset the stored options by `createSink`.
   
   Currently, the test suite is tying a workaround pattern. However, we 
observed a flakiness sometimes.
   ```
   val query = df.writeStream.
      ...
      .start()
   assert(LastOptions.paramters(..))
   query.stop()
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. This is a test-only change.
   
   ### How was this patch tested?
   
   Pass the newly updated test case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to