c21 commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r487249765
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -189,11 +189,9 @@ case class StreamingSymmetricHashJoinExec(
override def outputPartitioning: Partitioning = joinType match {
case _: InnerLike =>
PartitioningCollection(Seq(left.outputPartitioning,
right.outputPartitioning))
- case LeftOuter => PartitioningCollection(Seq(left.outputPartitioning))
- case RightOuter => PartitioningCollection(Seq(right.outputPartitioning))
- case x =>
- throw new IllegalArgumentException(
- s"${getClass.getSimpleName} should not take $x as the JoinType")
+ case LeftOuter => left.outputPartitioning
+ case RightOuter => right.outputPartitioning
+ case _ => throwBadJoinTypeException()
Review comment:
@xuanyuanking - sorry that I don't get how to change, are you suggesting
to have a string val for error message to be used in `throwBadJoinTypeException
` and `require(...)`: `val errorMessageForJoinType =
s"${getClass.getSimpleName} should not take $joinType as the JoinType")`, or
something else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
