gengliangwang commented on a change in pull request #29728:
URL: https://github.com/apache/spark/pull/29728#discussion_r487147769
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1327,22 +1327,26 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
override def visitComparison(ctx: ComparisonContext): Expression =
withOrigin(ctx) {
val left = expression(ctx.left)
val right = expression(ctx.right)
+ val hasBinaryComparisons = left.isInstanceOf[BinaryComparison] ||
Review comment:
nit: hasBinaryComparisons => hasBinaryComparisonChildren
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##########
@@ -306,6 +306,15 @@ class SparkSqlParserSuite extends AnalysisTest {
Project(UnresolvedAlias(concat) :: Nil,
UnresolvedRelation(TableIdentifier("t"))))
}
+ test("Prohibit binary comparisons chain") {
+ assertEqual("SELECT a = b",
+ Project(UnresolvedAlias(EqualTo(UnresolvedAttribute("a"),
UnresolvedAttribute("b"))) :: Nil,
+ OneRowRelation()))
+
+ intercept("SELECT a = b = c", "Syntax error at or near")
Review comment:
Nit: Let's add more cases to cover all the comparisions
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1327,22 +1327,26 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
override def visitComparison(ctx: ComparisonContext): Expression =
withOrigin(ctx) {
val left = expression(ctx.left)
val right = expression(ctx.right)
+ val hasBinaryComparisons = left.isInstanceOf[BinaryComparison] ||
Review comment:
nit: hasBinaryComparisons => hasBinaryComparisonChildren
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##########
@@ -306,6 +306,15 @@ class SparkSqlParserSuite extends AnalysisTest {
Project(UnresolvedAlias(concat) :: Nil,
UnresolvedRelation(TableIdentifier("t"))))
}
+ test("Prohibit binary comparisons chain") {
+ assertEqual("SELECT a = b",
+ Project(UnresolvedAlias(EqualTo(UnresolvedAttribute("a"),
UnresolvedAttribute("b"))) :: Nil,
+ OneRowRelation()))
+
+ intercept("SELECT a = b = c", "Syntax error at or near")
Review comment:
Nit: Let's add more cases to cover all the comparisions
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1327,22 +1327,26 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
override def visitComparison(ctx: ComparisonContext): Expression =
withOrigin(ctx) {
val left = expression(ctx.left)
val right = expression(ctx.right)
+ val hasBinaryComparisons = left.isInstanceOf[BinaryComparison] ||
Review comment:
nit: hasBinaryComparisons => hasBinaryComparisonChildren
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##########
@@ -306,6 +306,15 @@ class SparkSqlParserSuite extends AnalysisTest {
Project(UnresolvedAlias(concat) :: Nil,
UnresolvedRelation(TableIdentifier("t"))))
}
+ test("Prohibit binary comparisons chain") {
+ assertEqual("SELECT a = b",
+ Project(UnresolvedAlias(EqualTo(UnresolvedAttribute("a"),
UnresolvedAttribute("b"))) :: Nil,
+ OneRowRelation()))
+
+ intercept("SELECT a = b = c", "Syntax error at or near")
Review comment:
Nit: Let's add more cases to cover all the comparisions
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1327,22 +1327,26 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
override def visitComparison(ctx: ComparisonContext): Expression =
withOrigin(ctx) {
val left = expression(ctx.left)
val right = expression(ctx.right)
+ val hasBinaryComparisons = left.isInstanceOf[BinaryComparison] ||
Review comment:
nit: hasBinaryComparisons => hasBinaryComparisonChildren
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##########
@@ -306,6 +306,15 @@ class SparkSqlParserSuite extends AnalysisTest {
Project(UnresolvedAlias(concat) :: Nil,
UnresolvedRelation(TableIdentifier("t"))))
}
+ test("Prohibit binary comparisons chain") {
+ assertEqual("SELECT a = b",
+ Project(UnresolvedAlias(EqualTo(UnresolvedAttribute("a"),
UnresolvedAttribute("b"))) :: Nil,
+ OneRowRelation()))
+
+ intercept("SELECT a = b = c", "Syntax error at or near")
Review comment:
Nit: Let's add more cases to cover all the comparisions
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1327,22 +1327,26 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
override def visitComparison(ctx: ComparisonContext): Expression =
withOrigin(ctx) {
val left = expression(ctx.left)
val right = expression(ctx.right)
+ val hasBinaryComparisons = left.isInstanceOf[BinaryComparison] ||
Review comment:
nit: hasBinaryComparisons => hasBinaryComparisonChildren
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##########
@@ -306,6 +306,15 @@ class SparkSqlParserSuite extends AnalysisTest {
Project(UnresolvedAlias(concat) :: Nil,
UnresolvedRelation(TableIdentifier("t"))))
}
+ test("Prohibit binary comparisons chain") {
+ assertEqual("SELECT a = b",
+ Project(UnresolvedAlias(EqualTo(UnresolvedAttribute("a"),
UnresolvedAttribute("b"))) :: Nil,
+ OneRowRelation()))
+
+ intercept("SELECT a = b = c", "Syntax error at or near")
Review comment:
Nit: Let's add more cases to cover all the comparisions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
