HyukjinKwon commented on a change in pull request #29720:
URL: https://github.com/apache/spark/pull/29720#discussion_r486794529
##########
File path: python/pyspark/sql/types.py
##########
@@ -305,7 +305,7 @@ def jsonValue(self):
@classmethod
def fromJson(cls, json):
return ArrayType(_parse_datatype_json_value(json["elementType"]),
- json["containsNull"])
+ json.get("containsNull", True))
Review comment:
Just to clarify, does this cause any user-facing error? This isn't an
API so we're good if it works internally.
##########
File path: python/pyspark/sql/types.py
##########
@@ -305,7 +305,7 @@ def jsonValue(self):
@classmethod
def fromJson(cls, json):
Review comment:
Just to clarify, does this cause any user-facing error? As long as we
can roundtrip jsonValue and fromJson, I think we're good.
##########
File path: python/pyspark/sql/types.py
##########
@@ -305,7 +305,7 @@ def jsonValue(self):
@classmethod
def fromJson(cls, json):
return ArrayType(_parse_datatype_json_value(json["elementType"]),
- json["containsNull"])
+ json.get("containsNull", True))
Review comment:
Just to clarify, does this cause any user-facing error? This isn't an
API so we're good if it works internally.
##########
File path: python/pyspark/sql/types.py
##########
@@ -305,7 +305,7 @@ def jsonValue(self):
@classmethod
def fromJson(cls, json):
Review comment:
Just to clarify, does this cause any user-facing error? As long as we
can roundtrip jsonValue and fromJson, I think we're good.
##########
File path: python/pyspark/sql/types.py
##########
@@ -305,7 +305,7 @@ def jsonValue(self):
@classmethod
def fromJson(cls, json):
return ArrayType(_parse_datatype_json_value(json["elementType"]),
- json["containsNull"])
+ json.get("containsNull", True))
Review comment:
Just to clarify, does this cause any user-facing error? This isn't an
API so we're good if it works internally.
##########
File path: python/pyspark/sql/types.py
##########
@@ -305,7 +305,7 @@ def jsonValue(self):
@classmethod
def fromJson(cls, json):
Review comment:
Just to clarify, does this cause any user-facing error? As long as we
can roundtrip jsonValue and fromJson, I think we're good.
##########
File path: python/pyspark/sql/types.py
##########
@@ -305,7 +305,7 @@ def jsonValue(self):
@classmethod
def fromJson(cls, json):
return ArrayType(_parse_datatype_json_value(json["elementType"]),
- json["containsNull"])
+ json.get("containsNull", True))
Review comment:
Just to clarify, does this cause any user-facing error? This isn't an
API so we're good if it works internally.
##########
File path: python/pyspark/sql/types.py
##########
@@ -305,7 +305,7 @@ def jsonValue(self):
@classmethod
def fromJson(cls, json):
Review comment:
Just to clarify, does this cause any user-facing error? As long as we
can roundtrip jsonValue and fromJson, I think we're good.
##########
File path: python/pyspark/sql/types.py
##########
@@ -305,7 +305,7 @@ def jsonValue(self):
@classmethod
def fromJson(cls, json):
return ArrayType(_parse_datatype_json_value(json["elementType"]),
- json["containsNull"])
+ json.get("containsNull", True))
Review comment:
Just to clarify, does this cause any user-facing error? This isn't an
API so we're good if it works internally.
##########
File path: python/pyspark/sql/types.py
##########
@@ -305,7 +305,7 @@ def jsonValue(self):
@classmethod
def fromJson(cls, json):
Review comment:
Just to clarify, does this cause any user-facing error? As long as we
can roundtrip jsonValue and fromJson, I think we're good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
