HeartSaVioR commented on a change in pull request #29724:
URL: https://github.com/apache/spark/pull/29724#discussion_r486993687
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here
is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching
new left input with
Review comment:
The comment seems to be just modified for replacing
`leftJoiner.joinWith(rightJoiner)` with
`leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for
right side. Other parts aren't modified.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here
is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching
new left input with
Review comment:
The comment seems to be just modified for replacing
`leftJoiner.joinWith(rightJoiner)` with
`leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for
right side. Other parts aren't modified.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here
is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching
new left input with
Review comment:
The comment seems to be just modified for replacing
`leftJoiner.joinWith(rightJoiner)` with
`leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for
right side. Other parts aren't modified.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here
is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching
new left input with
Review comment:
The comment seems to be just modified for replacing
`leftJoiner.joinWith(rightJoiner)` with
`leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for
right side. Other parts aren't modified.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here
is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching
new left input with
Review comment:
The comment seems to be just modified for replacing
`leftJoiner.joinWith(rightJoiner)` with
`leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for
right side. Other parts aren't modified.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here
is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching
new left input with
Review comment:
The comment seems to be just modified for replacing
`leftJoiner.joinWith(rightJoiner)` with
`leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for
right side. Other parts aren't modified.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -246,13 +244,14 @@ case class StreamingSymmetricHashJoinExec(
// Join one side input using the other side's buffered/state rows. Here
is how it is done.
//
- // - `leftJoiner.joinWith(rightJoiner)` generates all rows from matching
new left input with
Review comment:
The comment seems to be just modified for replacing
`leftJoiner.joinWith(rightJoiner)` with
`leftSideJoiner.storeAndJoinWithOtherSide(rightSideJoiner)` and vice versa for
right side. Other parts aren't modified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
