dongjoon-hyun commented on a change in pull request #29587:
URL: https://github.com/apache/spark/pull/29587#discussion_r487484075
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/types/StructTypeSuite.scala
##########
@@ -103,4 +105,112 @@ class StructTypeSuite extends SparkFunSuite {
val interval = "`a` INTERVAL"
assert(fromDDL(interval).toDDL === interval)
}
+
+ test("find missing (nested) fields") {
+ val schema = StructType.fromDDL(
+ "c1 INT, c2 STRUCT<c3: INT, c4: STRUCT<c5: INT, c6: INT>>")
+ val resolver = SQLConf.get.resolver
+
+ val source1 = StructType.fromDDL("c1 INT")
+ val missing1 = StructType.fromDDL(
+ "c2 STRUCT<c3: INT, c4: STRUCT<c5: INT, c6: INT>>")
+ assert(StructType.findMissingFields(source1, schema, resolver)
+ .exists(_.sameType(missing1)))
+
+ val source2 = StructType.fromDDL("c1 INT, c3 STRING")
+ val missing2 = StructType.fromDDL(
+ "c2 STRUCT<c3: INT, c4: STRUCT<c5: INT, c6: INT>>")
+ assert(StructType.findMissingFields(source2, schema, resolver)
+ .exists(_.sameType(missing2)))
+
+ val source3 = StructType.fromDDL("c1 INT, c2 STRUCT<c3: INT>")
+ val missing3 = StructType.fromDDL(
+ "c2 STRUCT<c4: STRUCT<c5: INT, c6: INT>>")
+ assert(StructType.findMissingFields(source3, schema, resolver)
+ .exists(_.sameType(missing3)))
+
+ val source4 = StructType.fromDDL("c1 INT, c2 STRUCT<c3: INT, c4:
STRUCT<c6: INT>>")
+ val missing4 = StructType.fromDDL(
+ "c2 STRUCT<c4: STRUCT<c5: INT>>")
Review comment:
Shall we make this as a one-liner?
```scala
val source4 = StructType.fromDDL("c1 INT, c2 STRUCT<c3: INT, c4:
STRUCT<c6: INT>>")
- val missing4 = StructType.fromDDL(
- "c2 STRUCT<c4: STRUCT<c5: INT>>")
+ val missing4 = StructType.fromDDL("c2 STRUCT<c4: STRUCT<c5: INT>>")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
