Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5350#discussion_r27750860
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SpecificMutableRow.scala
---
@@ -230,13 +251,17 @@ final class SpecificMutableRow(val values:
Array[MutableValue]) extends MutableR
new GenericRow(newValues)
}
- override def update(ordinal: Int, value: Any): Unit = {
- if (value == null) setNullAt(ordinal) else
values(ordinal).update(value)
+ override def update(ordinal: Int, value: Any): Unit = value match {
+ case null => setNullAt(ordinal)
+ case s: String =>
+ // for tests
+ throw new Exception("String should be converted into UTF8String")
+ case other => values(ordinal).update(value)
--- End diff --
I'm not actually sure, but I wonder if it would be faster to do a plain
null check followed by an asInstanceOf, rather than pattern matching. You will
still get a class cast exception in tests if there is a mistake.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
