LuciferYang commented on a change in pull request #29711:
URL: https://github.com/apache/spark/pull/29711#discussion_r487615921
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
##########
@@ -316,7 +323,7 @@ object JoinReorderDP extends PredicateHelper with Logging {
}
/** Map[set of item ids, join plan for these items] */
- type JoinPlanMap = Map[Set[Int], JoinPlan]
+ type JoinPlanMap = mutable.LinkedHashMap[Set[Int], JoinPlan]
Review comment:
> Same JIRA I think, just a separate PR. I'm not sure it matters that
much though, it's a tiny part of the change really? we just need more eyes on
the plan changes.
It seems that there is no way to divide 2 PR because if we change
`CostBasedJoinReorder ` only, the test cases in `sql/core` module will be
failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
