cloud-fan commented on a change in pull request #29722:
URL: https://github.com/apache/spark/pull/29722#discussion_r487699399
##########
File path: core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala
##########
@@ -61,13 +61,28 @@ private[deploy] object DeployMessages {
}
/**
+ * An internal message that used by Master itself, in order to handle the
+ * `DecommissionWorkersOnHosts` request from `MasterWebUI` asynchronously.
+ * @param ids A collection of Worker ids, which should be decommissioned.
+ */
+ case class DecommissionWorkers(ids: Seq[String])
+
+ /**
+ * A message that sent from Master to Worker to decommission the Worker.
+ * It's used for the case where decommission is triggered at MasterWebUI.
+ *
+ * Note that decommission a Worker will cause all the executors on that
Worker
+ * to be decommissioned as well.
+ */
+ object DecommissionWorker extends DeployMessage
+
+ /**
+ * A message that sent from Worker to Master to tell Master that the Worker
has been
+ * decommissioned. It's used for the case where decommission is triggered at
Worker.
+ *
* @param id the worker id
- * @param worker the worker endpoint ref
*/
- case class WorkerDecommission(
- id: String,
- worker: RpcEndpointRef)
- extends DeployMessage
+ case class WorkerDecommissioned(id: String, workerRef: RpcEndpointRef)
extends DeployMessage
Review comment:
how about `WorkerDecommissioning`? The worker is not decommissioned yet
when sending this event.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
