tanelk commented on a change in pull request #29743:
URL: https://github.com/apache/spark/pull/29743#discussion_r487703871
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
##########
@@ -426,8 +427,16 @@ abstract class OffsetWindowFunction
* default - a string expression which is to use when the offset is
larger than the window.
The default value is null.
""",
+ examples = """
+ Examples:
+ > SELECT a, b, _FUNC_(b) OVER (PARTITION BY a ORDER BY b) FROM VALUES
('A1', 2), ('A2', 3), ('A1', 1) tab(a, b);
+ A1 1 2
+ A1 2 NULL
+ A2 3 NULL
Review comment:
Do you mean using spaces instead of tabs?
The `check outputs of expression examples` in `ExpressionInfoSuite` does a
string comparison on requires a tab to be the column separator.
All the other examples I checked also use tabs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
