Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/5096#issuecomment-89422690
I took a pass on this. I still haven't wrapped my head totally around the
packaging, but here are a few comments:
- Iâm not quite sure what all the scripts are for. Can we document or
remove some of these? It would be helpful to explain the general packaging
mechanisms somewhere. For instance the install script seems important, but I
donât get what âinstallâ means in this context (vs âpackageâ).
- We should file as a blocker for 1.4 integrating the docs into our doc
build and our published API docs.
- All of the examples use the Spark core API, but I imagine one of the
biggest use cases would be using Data frames. What about an example that uses
the data frame API?
- Changes to Spark submit look good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]