HyukjinKwon commented on a change in pull request #29699:
URL: https://github.com/apache/spark/pull/29699#discussion_r487883751
##########
File path: python/pyspark/sql/tests/test_column.py
##########
@@ -139,6 +139,33 @@ def test_bitwise_operations(self):
result = df.select(functions.bitwiseNOT(df.b)).collect()[0].asDict()
self.assertEqual(~75, result['~b'])
+ def test_with_field(self):
Review comment:
Oh I meant, the test cases you added in doctests look good enough as
positive cases. So, we can remove this test you added at `test_column.py`.
Instead, I think we can have some tests that check exception types and
messages here at `test_column.py`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
