agrawaldevesh commented on a change in pull request #29722:
URL: https://github.com/apache/spark/pull/29722#discussion_r488071027
##########
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##########
@@ -79,12 +79,23 @@ private[spark] class CoarseGrainedExecutorBackend(
*/
private[executor] val taskResources = new mutable.HashMap[Long, Map[String,
ResourceInformation]]
- @volatile private var decommissioned = false
+ private var decommissioned = false
override def onStart(): Unit = {
- logInfo("Registering PWR handler.")
- SignalUtils.register("PWR", "Failed to register SIGPWR handler - " +
- "disabling decommission feature.")(decommissionSelf)
+ if (env.conf.get(DECOMMISSION_ENABLED)) {
+ logInfo("Registering PWR handler to trigger decommissioning.")
+ SignalUtils.register("PWR", "Failed to register SIGPWR handler - " +
+ "disabling executor decommission feature.") {
+ self.send(DecommissionExecutor)
Review comment:
Okay I think I understand why ExecutorDecommissioning is only sent in
this SIGPWR case: What do you think of introducing a new message like
ExecutorSigPwrReceived and handle that in the event loop ? I am wary of doing
all this work in the signal handling context. I would prefer it being done in
the regular event loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
