[GitHub] [spark] sunchao commented on a change in pull request #29654: [SPARK-32802][SQL] Avoid using SpecificInternalRow in RunLengthEncoding#Encoder

[GitBox]

sunchao commented on a change in pull request #29654:
URL: https://github.com/apache/spark/pull/29654#discussion_r488150906



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/compressionSchemes.scala
##########
@@ -182,8 +181,7 @@ private[columnar] case object RunLengthEncoding extends 
CompressionScheme {
     private var _uncompressedSize = 0
     private var _compressedSize = 0
 
-    // Using `MutableRow` to store the last value to avoid boxing/unboxing 
cost.

Review comment:
       @viirya Sure. Here's complete graphs
   
   Before:
   
   <img width="1194" alt="Screen Shot 2020-09-14 at 11 45 43 AM" 
src="https://user-images.githubusercontent.com/506679/93125938-a86a3180-f680-11ea-9d31-f48dd804307c.png";>
   
   After:
   
   <img width="1193" alt="Screen Shot 2020-09-14 at 11 45 52 AM" 
src="https://user-images.githubusercontent.com/506679/93125954-abfdb880-f680-11ea-9259-862683db117c.png";>
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org