HyukjinKwon commented on a change in pull request #29720:
URL: https://github.com/apache/spark/pull/29720#discussion_r488334221
##########
File path: python/pyspark/sql/types.py
##########
@@ -305,7 +305,7 @@ def jsonValue(self):
@classmethod
def fromJson(cls, json):
Review comment:
I don't think the format is meant to be exposed from end users. It's
just for internal ser/de purpose that is supposed to be roundtrip between
`jsonValue` and `fromJson` to workaround Py4J limitation.
BTW, here isn't only place where you should handle JSON ser/de. For example,
you should also change Scala side at `DataType.parseDataType`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
