Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5096#issuecomment-89479811
Spark submit changes look fine for the most part. The comments I left are
mostly minor. One thing I noticed is that there are a lot of places where the
return type is not specified. Even if a method has no return type, we should
try to enforce adding `Unit` to the end so developers new to the project will
do the same.
I intend to take another pass after the comments are addressed. I have not
looked in detail at changes outside of Spark submit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
