gaborgsomogyi commented on a change in pull request #29729:
URL: https://github.com/apache/spark/pull/29729#discussion_r488456887
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala
##########
@@ -689,57 +691,6 @@ abstract class KafkaMicroBatchSourceSuiteBase extends
KafkaSourceSuiteBase {
)
}
- test("allow group.id prefix") {
Review comment:
Related removing "exact" assign of groupId (`kafka.group.id`) not sure
what you mean. GroupId can be overwritten on executor side too. Please see
(generated GroupId is set only if not overriden):
https://github.com/apache/spark/blob/99384d1e831b7fe82a3a80ade1da976971624ee7/external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala#L609
I've recalled and from test perspective now I remember what was the
situation. Originally there were no tests which covered prefix + override
features. I've added the tests which covered driver side but the approach was
not working for executors so not added such test. This still stands so unless
somebody has an idea we can't use this approach to cover executor side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
