tanelk commented on a change in pull request #29743:
URL: https://github.com/apache/spark/pull/29743#discussion_r488475246
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala
##########
@@ -105,11 +105,34 @@ class ExpressionInfoSuite extends SparkFunSuite with
SharedSparkSession {
}
}
+ test("SPARK-32870: Default expressions in FunctionRegistry should have their
" +
+ "usage, examples and since filled") {
+ val ignoreSet = Set(
+ "org.apache.spark.sql.catalyst.expressions.TimeWindow")
+
+ spark.sessionState.functionRegistry.listFunction().foreach { funcId =>
+ val info = spark.sessionState.catalog.lookupFunctionInfo(funcId)
+ if (!ignoreSet.contains(info.getClassName)) {
+ withClue(s"Function '${info.getName}', Expression class
'${info.getClassName}'") {
+ assert(info.getUsage.nonEmpty)
+ assert(info.getExamples.startsWith("\n Examples:\n"))
+ assert(info.getExamples.endsWith("\n "))
+ assert(info.getSince.matches("[0-9]+\\.[0-9]+\\.[0-9]+"))
Review comment:
No, problems with current ones - only some dummy functions in tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
