HeartSaVioR commented on a change in pull request #29756:
URL: https://github.com/apache/spark/pull/29756#discussion_r489141439
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamProviderSuite.scala
##########
@@ -78,6 +78,22 @@ class RateStreamProviderSuite extends StreamTest {
)
}
+ test("stream table API support") {
Review comment:
I don't think this test should be here. The origin goal of the test is
to verify reading from temp view via `readStream.table`, right? This should be
placed in DataStreamTableAPISuite, and probably don't need to be related to the
rate stream.
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala
##########
@@ -815,3 +815,26 @@ class DataStreamReaderWriterSuite extends StreamTest with
BeforeAndAfter {
}
}
}
+
+class DataStreamTableAPISuite extends StreamTest with BeforeAndAfter {
+ test("table API") {
Review comment:
Looks like tests are not sufficient. Please take a look at the cases I
covered in my PR:
https://github.com/apache/spark/pull/29767/files#diff-20df0514e33057039a03be7442a439c1R822-R948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
