gaborgsomogyi commented on a change in pull request #29729: URL: https://github.com/apache/spark/pull/29729#discussion_r489215473
########## File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala ########## @@ -105,34 +109,16 @@ private[kafka010] class KafkaOffsetReader( minPartitions.map(_ > numTopicPartitions).getOrElse(false) } - private def nextGroupId(): String = { - groupId = driverGroupIdPrefix + "-" + nextId - nextId += 1 - groupId - } - override def toString(): String = consumerStrategy.toString /** * Closes the connection to Kafka, and cleans up state. */ def close(): Unit = { - if (_consumer != null) uninterruptibleThreadRunner.runUninterruptibly { stopConsumer() } + if (_admin != null) uninterruptibleThreadRunner.runUninterruptibly { stopAdmin() } uninterruptibleThreadRunner.shutdown() } - /** - * @return The Set of TopicPartitions for a given topic - */ - def fetchTopicPartitions(): Set[TopicPartition] = uninterruptibleThreadRunner.runUninterruptibly { - assert(Thread.currentThread().isInstanceOf[UninterruptibleThread]) Review comment: My rationale related removing here vs removing in separate PR is the following: I personally don't see a reason why the removal could cause any issues but to be defensive we can put it into a separate PR. This way if any issue appears for mystical reason we can rollback that PR independently. Does this make sense? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org