beliefer commented on a change in pull request #29604:
URL: https://github.com/apache/spark/pull/29604#discussion_r489252543
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
##########
@@ -233,6 +233,17 @@ class AnalysisErrorSuite extends AnalysisTest {
SpecifiedWindowFrame(RangeFrame, Literal(1),
Literal(2)))).as("window")),
"window frame" :: "must match the required frame" :: Nil)
+ errorTest(
+ "nth_value window function",
+ testRelation2.select(
+ WindowExpression(
+ new NthValue(AttributeReference("b", IntegerType)(), Literal(0)),
+ WindowSpecDefinition(
+ UnresolvedAttribute("a") :: Nil,
+ SortOrder(UnresolvedAttribute("b"), Ascending) :: Nil,
+ SpecifiedWindowFrame(RowFrame, Literal(0),
Literal(0)))).as("window")),
+ "The 'offset' argument of nth_value must be greater than zero but it is
0." :: Nil)
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
