jzc928 commented on a change in pull request #29761:
URL: https://github.com/apache/spark/pull/29761#discussion_r489322068
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -2242,6 +2242,29 @@ abstract class SQLQuerySuiteBase extends QueryTest with
SQLTestUtils with TestHi
}
}
+ test("SPARK-32889 ORC table column name supports special characters like $
eg.") {
Review comment:
thank you. @dongjoon-hyun
In data source. orc and json column name almost supports all characters.
parquet support all except `.*[ ,;{}()\n\t=].*`
csv doesn't support `\r \n` and so on.
they are all different. this pr is make orc sql support special chars.
shoud we add orc unit test in FileBasedDataSourceSuite only in this pr ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
