tomvanbussel commented on a change in pull request #29772:
URL: https://github.com/apache/spark/pull/29772#discussion_r489435297
##########
File path:
core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java
##########
@@ -359,6 +359,38 @@ public void forcedSpillingWithReadIterator() throws
Exception {
assertSpillFilesWereCleanedUp();
}
+ @Test
+ public void forcedSpillingNullsWithReadIterator() throws Exception {
+ final UnsafeExternalSorter sorter = newSorter();
+ long[] record = new long[100];
+ final int recordSize = record.length * 8;
+ final int n = (int) pageSizeBytes / recordSize * 3;
+ for (int i = 0; i < n; i++) {
+ sorter.insertRecord(record, Platform.LONG_ARRAY_OFFSET, recordSize, 0,
true);
Review comment:
Made every odd index non-null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
